Re: [PATCH v5 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO

On Wed, Jan 14, 2026 at 04:43:35PM +0100, Krzysztof Kozlowski wrote:
> On 14/01/2026 16:13, Stafford Horne wrote:
> > In commit f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible
> > string for opencores,gpio") we marked opencores,gpio to be allowed with
> > brcm,bcm6345-gpio. This was wrong, opencores,gpio is not hardware
> > equivalent to brcm,bcm6345-gpio. It has a different register map and
> 
> "is not compatible with brcm,...."

OK.

> > is 8-bit vs braodcom which is 32-bit.  Change opencores,gpio to be a
> > separate compatible string for MMIO GPIO.
> > 
> > Fixes: f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string for opencores,gpio")
> > Signed-off-by: Stafford Horne <[email protected]>
> > ---
> > Since v4:
> >  - New patch.
> >  - Rebased old patch and rewrote commit message.
> > 
> >  .../devicetree/bindings/gpio/gpio-mmio.yaml      | 16 ++++++----------
> >  1 file changed, 6 insertions(+), 10 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > index 7ee40b9bc562..a8823ca65e78 100644
> > --- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > @@ -18,16 +18,12 @@ description:
> >  
> >  properties:
> >    compatible:
> > -    oneOf:
> > -      - enum:
> > -          - brcm,bcm6345-gpio
> > -          - ni,169445-nand-gpio
> > -          - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
> > -          - intel,ixp4xx-expansion-bus-mmio-gpio
> > -      - items:
> > -          - enum:
> > -              - opencores,gpio
> > -          - const: brcm,bcm6345-gpio
> > +    enum:
> > +      - brcm,bcm6345-gpio
> > +      - ni,169445-nand-gpio
> > +      - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
> > +      - intel,ixp4xx-expansion-bus-mmio-gpio
> > +      - opencores,gpio
> 
> So if you are changing all of the lines here, you can as well sort it
> and put the new entry not at the end but in alphabetical spot.

OK, I will sort the list and mention that in commit message in v6.

> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Thanks,

-Stafford