Re: [PATCH] net: tulip: xircom_cb: drop runt frames before skb copy
Jakub Kicinski <[email protected]> Fri, 31 Jul 2026 16:55:55 -0700
| Newsgroups | org.kernel.vger.linux-parisc,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 31 Jul 2026 22:56:02 +0200 Pablo Vallesp=C3=ADn Aranguren wrote: > > Have you checked that that hardware can actually set a short value? > > I'd expect that packets shorter than 64 bytes (including the crc) are > > dropped as 'runts' and probably don't even use a ring entry. =20 >=20 > I haven't verified how the real Xircom firmware handles runt frames (I > don't own this hardware). I tested with Qemu's emulated NIC, the device > itself does validate and reject negative-size values before sending them > to the driver. Are you related to Greg KH in any way? You use the same slop tag. Just curious. Please send a patch to delete this driver if you want to help. It's ancient.