Re: [PATCH] net: tulip: xircom_cb: drop runt frames before skb copy

On Fri, Jul 31, 2026 at 04:55:55PM -0700, Jakub Kicinski wrote:
> On Fri, 31 Jul 2026 22:56:02 +0200 Pablo Vallespín Aranguren wrote:
> > > Have you checked that that hardware can actually set a short value?
> > > I'd expect that packets shorter than 64 bytes (including the crc) are
> > > dropped as 'runts' and probably don't even use a ring entry.  
> > 
> > I haven't verified how the real Xircom firmware handles runt frames (I
> > don't own this hardware). I tested with Qemu's emulated NIC, the device
> > itself does validate and reject negative-size values before sending them
> > to the driver.
> 
> Are you related to Greg KH in any way? You use the same slop tag.
> Just curious.

Pablo is part of an CS masters intern project through vu.nl that I'm
running to help audit and submit LLM-found issues against the kernel.
Hence the gkh_clanker tag, as my bot is the thing that originally
"found" this report.

> Please send a patch to delete this driver if you want to help.
> It's ancient.

No objection from me, that fixes all of the issues!

Pablo, want to submit a patch for that?

thanks,

greg k-h