Re: [PATCH v2 3/5] rust: pci: remove request_irq() and request_threaded_irq() from Device
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> Remove the thin wrappers on Device<Bound> that only forwarded to > irq::Registration::new() and irq::ThreadedRegistration::new(). With > IrqVector embedding a resolved IrqRequest, the conversion is infallible > and drivers call irq::Registration::new(vector.into(), ...) directly. > > Unlike the platform equivalents, which combine a fallible IRQ lookup > with handler registration, the PCI wrappers add no value beyond > namespacing. They also introduce a redundant device reference. > IrqVector already carries a device borrow through its embedded > IrqRequest, yet the wrappers required a second, potentially unrelated, > &self receiver. > > Signed-off-by: Danilo Krummrich <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3