Re: [PATCH v2 2/5] rust: pci: resolve IRQ in vector() and embed IrqRequest in IrqVector
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> Move the pci_irq_vector() call from the TryInto<IrqRequest> impl into > IrqVectorRegistration::vector(), so the IRQ number is resolved eagerly. > > IrqVector now embeds the resolved IrqRequest and the vector index. The > conversion to IrqRequest is infallible (From instead of TryInto), which > removes the need for pin_init_scope in request_irq/request_threaded_irq. > > Inspired-by: John Hubbard <[email protected]> > Link: https://lore.kernel.org/all/[email protected]/ > Signed-off-by: Danilo Krummrich <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2