Re: [PATCH v1 2/2] perf annotate: Honor explicit --source option
| Newsgroups | org.kernel.vger.linux-perf-users |
|---|---|
| Message-ID | <[email protected]> |
> Source annotation is hidden by default to avoid forcing objdump -S, but
> currently an explicit --source doesn't override annotate.hide_src_code.
>
> In TUI mode, source code can be shown later with the 's' hotkey, which
> re-runs annotation with hide_src_code cleared. In --stdio/--stdio2 mode,
> there is no such interactive fallback, so --source did not show source
> code unless users also set annotate.hide_src_code=false globally in
> advance.
>
> Track whether --source/--no-source was specified and synchronize
> hide_src_code only in that case.
>
> Fixes: e201757f7a0a ("perf annotate: Fix source code annotate with objdump")
> Signed-off-by: Kohei Enju <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2