Re: [PATCH v1] perf top: Merge hybrid common events

> Thanks Andi, I agree with the frustration. For an event like
> instructions I would like things merged. Does merging make sense for
> cycles given the different clock frequencies of p-cores and e-cores?

Frequencies are always per core anyways, even on non hybrid systems.

> Should the e-core cycles be scaled for this reason as there are fewer
> cycles within a second compared to a p-core?

No.

> 
> Perhaps we need a new json field to describe the hybrid merge-ability
> of events, say enabled on events like instructions or cache misses.
> Note the legacy events now have JSON descriptions:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/pmu-events/arch/common/common/legacy-hardware.json?h=perf-tools-next

Makes sense. At least for architectural events it's easy.
But I'll also defer it for now.


> 
> It would be nice if this were a generic feature and not just for perf top.

Makes sense, but I would also defer that to a future version.
The utility code is already partly factored out for reuse.


-Andi