Re: [PATCH v6 2/3] dt-bindings: power: reset: fix minimum reg count for pmk8350-pon

On Mon, Jul 27, 2026 at 08:36:38AM +0200, Krzysztof Kozlowski wrote:
> On Fri, Jul 24, 2026 at 03:44:12PM +0530, Rakesh Kota wrote:
> > The GEN3 PON peripheral requires two register address spaces: "hlos"
> > for the primary PON block and "pbs" for the address needs to be
> > specified to facilitate software debouncing. Set minItems: 2 for reg
> 
> That's ABI break and I do not underestand if this was broken before or
> not. Driver ignores the PBS, so everything was working fine, no? Then
> why PBS is required now? Is it actually working or not?
>

Not an ABI break. All in-tree GEN3 DTs using qcom,pmk8350-pon have
always specified both "hlos" and "pbs" reg entries — pmk8350.dtsi,
pmk8550.dtsi, pmk8850.dtsi, sc8280xp-pmics.dtsi. No issues were seen
precisely because PBS was never omitted on any GEN3 platform.

minItems: 2 simply enforces in the schema what has always been present
in practice, ensuring future GEN3 DTs cannot accidentally omit the PBS
address space which is a GEN3 hardware requirement.

regards
Rakesh Kota

> > in the qcom,pmk8350-pon if/then constraint to enforce that both
> > address spaces are always present.
> > 
> > Signed-off-by: Rakesh Kota <[email protected]>
> > ---
> >  Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Best regards,
> Krzysztof
>