Re: [PATCH v6 2/3] dt-bindings: power: reset: fix minimum reg count for pmk8350-pon
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.linux-pm,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 28/07/2026 12:12, Rakesh Kota wrote: > On Mon, Jul 27, 2026 at 08:36:38AM +0200, Krzysztof Kozlowski wrote: >> On Fri, Jul 24, 2026 at 03:44:12PM +0530, Rakesh Kota wrote: >>> The GEN3 PON peripheral requires two register address spaces: "hlos" >>> for the primary PON block and "pbs" for the address needs to be >>> specified to facilitate software debouncing. Set minItems: 2 for reg >> >> That's ABI break and I do not underestand if this was broken before or >> not. Driver ignores the PBS, so everything was working fine, no? Then >> why PBS is required now? Is it actually working or not? >> > > Not an ABI break. All in-tree GEN3 DTs using qcom,pmk8350-pon have > always specified both "hlos" and "pbs" reg entries — pmk8350.dtsi, That's not related to ABI. What about my DTS? > pmk8550.dtsi, pmk8850.dtsi, sc8280xp-pmics.dtsi. No issues were seen > precisely because PBS was never omitted on any GEN3 platform. > > minItems: 2 simply enforces in the schema what has always been present > in practice, ensuring future GEN3 DTs cannot accidentally omit the PBS > address space which is a GEN3 hardware requirement. This does not answer my questions. Best regards, Krzysztof