RE: [PATCH v4 3/4] power: sequencing: Add Renesas RZ/G3L Power Ready driver

Biju Das <[email protected]>
Newsgroups org.kernel.vger.linux-pm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc
Message-ID <TY3PR01MB113467630111474706CE4196186A02@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: 24 August 2026 15:47
> Subject: Re: [PATCH v4 3/4] power: sequencing: Add Renesas RZ/G3L Power Ready driver
> 
> Hi Biju,
> 
> On Wed, 19 Aug 2026 at 21:13, Biju <[email protected]> wrote:
> > From: Biju Das <[email protected]>
> >
> > Add a power sequencing driver for the Renesas RZ/G3L PWRRDY module,
> > which signals power readiness for various IPs (USB, DSI, CSI etc.) on
> > the SoC. The driver binds as an auxiliary device to the parent SYSC
> > driver, using its regmap to toggle the SYS_PWRRDY_N register bits, and
> > exposes {usb,dsi,csi}-pwrrdy pwrseq targets.
> >
> > Signed-off-by: Biju Das <[email protected]>
> > ---
> > v3->v4:
> >  * Replace the large of_device_id structures by C strings, and
> >    using of_device_is_compatible() will reduce kernel size.
> >  * Replaced of_device.h -> of.h
> >  * Dropped local variable pwrseq from pwrseq_rzg3l_pwrrdy_probe().
> 
> Thanks for the update!
> 
> > --- /dev/null
> > +++ b/drivers/power/sequencing/pwrseq-renesas-pwrrdy.c
> 
> > +static int pwrseq_rzg3l_pwrrdy_match(struct pwrseq_device *pwrseq,
> > +                                    struct device *dev) {
> > +       if (of_device_is_compatible(dev->of_node, "renesas,r9a08g046-usbphy-ctrl") ||
> > +           of_device_is_compatible(dev->of_node, "renesas,r9a08g046-mipi-dsi"))
> > +               return PWRSEQ_MATCH_OK;
> 
> Nit: of_device_compatible_match() handled multiple entries.
> 
> Sorry, my fault, I accidentally copied and paste the wrong function name in my review of v3.

Ok, will switch to of_device_compatible_match().

Cheers,
Biju
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.