Re: [PATCH net-next 2/3] ppp: unify two channel structs
Sebastian Andrzej Siewior <[email protected]> Thu, 7 May 2026 09:40:51 +0200
| Newsgroups | org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 2026-05-07 13:53:30 [+0800], Qingfang Deng wrote: > > This patch is IMHO a bit too big and should be split. Also this kind of > > refactor looks very invasive and potentially regression prone. I think > > it should include a signficant self-test coverage increase. > This is indeed too big. But how do I split it without breaking the build? The current ppp tests would yell if you accidentally broke something? Sebastian