Re: [PATCH net-next 2/3] ppp: unify two channel structs
Qingfang Deng <[email protected]> Thu, 7 May 2026 16:33:36 +0800
| Newsgroups | org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 2026/5/7 15:40, Sebastian Andrzej Siewior wrote: > On 2026-05-07 13:53:30 [+0800], Qingfang Deng wrote: >>> This patch is IMHO a bit too big and should be split. Also this kind of >>> refactor looks very invasive and potentially regression prone. I think >>> it should include a signficant self-test coverage increase. >> This is indeed too big. But how do I split it without breaking the build? > The current ppp tests would yell if you accidentally broke something? By "breaking the build" I meant compile-time errors (due to API changes).