Re: [PATCH v5 4/4] rust: clk: use 'kernel vertical style' for imports

On Mon, 06 Jul 2026 11:37:15 -0300=0D
Daniel Almeida <[email protected]> wrote:=0D
=0D
> Convert all imports to use the new import style. This will make it easier=
=0D
> to land new changes in the future.=0D
> =0D
> No change of functionality implied.=0D
> =0D
> Link: https://docs.kernel.org/rust/coding-guidelines.html#imports=0D
> Signed-off-by: Daniel Almeida <[email protected]>=0D
=0D
Reviewed-by: Onur =C3=96zkan <[email protected]>=0D
=0D
> ---=0D
>  rust/kernel/clk.rs | 66 +++++++++++++++++++++++++++++++++++++++++-------=
------=0D
>  1 file changed, 50 insertions(+), 16 deletions(-)=0D
> =0D
> diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs=0D
> index b9a44f83843a..e677156ffd21 100644=0D
> --- a/rust/kernel/clk.rs=0D
> +++ b/rust/kernel/clk.rs=0D
> @@ -80,13 +80,23 @@ fn from(freq: Hertz) -> Self {=0D
>  mod common_clk {=0D
>      use super::Hertz;=0D
>      use crate::{=0D
> -        device::{Bound, Device},=0D
> -        error::{from_err_ptr, to_result, Result},=0D
> +        device::{=0D
> +            Bound,=0D
> +            Device, //=0D
> +        },=0D
> +        error::{=0D
> +            from_err_ptr,=0D
> +            to_result, //=0D
> +        },=0D
>          prelude::*,=0D
> -        sync::Arc,=0D
> +        sync::Arc, //=0D
>      };=0D
>  =0D
> -    use core::{marker::PhantomData, mem::ManuallyDrop, ptr};=0D
> +    use core::{=0D
> +        marker::PhantomData,=0D
> +        mem::ManuallyDrop,=0D
> +        ptr, //=0D
> +    };=0D
>  =0D
>      mod private {=0D
>          pub trait Sealed {}=0D
> @@ -193,9 +203,15 @@ impl<State: ClkState> From<Error<State>> for kernel:=
:error::Error {=0D
>          /// original [`Clk`], e.g.:=0D
>          ///=0D
>          /// ```=0D
> -        /// use kernel::clk::{Clk, Enabled, Unprepared};=0D
> -        /// use kernel::device::{Bound, Device};=0D
> -        /// use kernel::error::Result;=0D
> +        /// use kernel::clk::{=0D
> +        ///     Clk,=0D
> +        ///     Enabled,=0D
> +        ///     Unprepared, //=0D
> +        /// };=0D
> +        /// use kernel::device::{=0D
> +        ///     Bound,=0D
> +        ///     Device, //=0D
> +        /// };=0D
>          ///=0D
>          /// fn get_enabled(dev: &Device<Bound>) -> Result<Clk<Enabled>> =
{=0D
>          ///     let clk =3D Clk::<Unprepared>::get(dev, Some(c"apb_clk")=
)?=0D
> @@ -245,9 +261,17 @@ fn from(err: Error<State>) -> Self {=0D
>      /// The following example demonstrates how to obtain and configure a=
 clock for a device.=0D
>      ///=0D
>      /// ```=0D
> -    /// use kernel::clk::{Clk, Enabled, Hertz, Unprepared, Prepared};=0D
> -    /// use kernel::device::{Bound, Device};=0D
> -    /// use kernel::error::Result;=0D
> +    /// use kernel::clk::{=0D
> +    ///     Clk,=0D
> +    ///     Enabled,=0D
> +    ///     Hertz,=0D
> +    ///     Prepared,=0D
> +    ///     Unprepared, //=0D
> +    /// };=0D
> +    /// use kernel::device::{=0D
> +    ///     Bound,=0D
> +    ///     Device, //=0D
> +    /// };=0D
>      ///=0D
>      /// fn configure_clk(dev: &Device<Bound>) -> Result {=0D
>      ///     // The fastest way is to use a version of `Clk::get` for the=
 desired=0D
> @@ -292,8 +316,11 @@ fn from(err: Error<State>) -> Self {=0D
>      /// and move between the variants:=0D
>      ///=0D
>      /// ```=0D
> -    /// use kernel::clk::{Clk, Enabled, Prepared};=0D
> -    /// use kernel::error::Result;=0D
> +    /// use kernel::clk::{=0D
> +    ///     Clk,=0D
> +    ///     Enabled,=0D
> +    ///     Prepared, //=0D
> +    /// };=0D
>      ///=0D
>      /// enum DeviceClk {=0D
>      ///     Suspended(Clk<Prepared>),=0D
> @@ -323,8 +350,11 @@ fn from(err: Error<State>) -> Self {=0D
>      /// enable a clone of it:=0D
>      ///=0D
>      /// ```=0D
> -    /// use kernel::clk::{Clk, Enabled, Prepared};=0D
> -    /// use kernel::error::Result;=0D
> +    /// use kernel::clk::{=0D
> +    ///     Clk,=0D
> +    ///     Enabled,=0D
> +    ///     Prepared, //=0D
> +    /// };=0D
>      ///=0D
>      /// fn use_clk(prepared_clk: &Clk<Prepared>) -> Result {=0D
>      ///     let enabled_clk: Clk<Enabled> =3D prepared_clk.clone().enabl=
e()?;=0D
> @@ -556,8 +586,12 @@ pub fn enable(self) -> Result<Clk<Enabled>, Error<Pr=
epared>> {=0D
>          /// clock or threading it through an intermediate state, e.g.:=0D
>          ///=0D
>          /// ```=0D
> -        /// use kernel::clk::{Clk, Enabled, Hertz, Prepared};=0D
> -        /// use kernel::error::Result;=0D
> +        /// use kernel::clk::{=0D
> +        ///     Clk,=0D
> +        ///     Enabled,=0D
> +        ///     Hertz,=0D
> +        ///     Prepared, //=0D
> +        /// };=0D
>          ///=0D
>          /// fn read_rate(clk: &Clk<Prepared>) -> Result<Hertz> {=0D
>          ///     clk.with_enabled(|clk: &Clk<Enabled>| clk.rate())=0D
> =0D
> -- =0D
> 2.54.0=0D
> =0D