[PATCH 1/2] rpmsg: glink: Remove redundant dev_err()

Pan Chuang <[email protected]> Thu, 16 Jul 2026 21:08:29 +0800
Newsgroups org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <[email protected]>
---
 drivers/rpmsg/qcom_glink_rpm.c  | 4 +---
 drivers/rpmsg/qcom_glink_smem.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/rpmsg/qcom_glink_rpm.c b/drivers/rpmsg/qcom_glink_rpm.c
index e3ba2c63a5fc..0662c0668f75 100644
--- a/drivers/rpmsg/qcom_glink_rpm.c
+++ b/drivers/rpmsg/qcom_glink_rpm.c
@@ -320,10 +320,8 @@ static int glink_rpm_probe(struct platform_device *pdev)
 	ret = devm_request_irq(dev, rpm->irq, qcom_glink_rpm_intr,
 			       IRQF_NO_SUSPEND | IRQF_NO_AUTOEN,
 			       "glink-rpm", rpm);
-	if (ret) {
-		dev_err(dev, "failed to request IRQ\n");
+	if (ret)
 		return ret;
-	}
 
 	rpm->mbox_client.dev = dev;
 	rpm->mbox_client.knows_txdone = true;
diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c
index 35bb03e67ae8..2217a1573b16 100644
--- a/drivers/rpmsg/qcom_glink_smem.c
+++ b/drivers/rpmsg/qcom_glink_smem.c
@@ -315,10 +315,8 @@ struct qcom_glink_smem *qcom_glink_smem_register(struct device *parent,
 	ret = devm_request_irq(&smem->dev, smem->irq, qcom_glink_smem_intr,
 			       IRQF_NO_SUSPEND | IRQF_NO_AUTOEN,
 			       "glink-smem", smem);
-	if (ret) {
-		dev_err(&smem->dev, "failed to request IRQ\n");
+	if (ret)
 		goto err_put_dev;
-	}
 
 	smem->mbox_client.dev = &smem->dev;
 	smem->mbox_client.knows_txdone = true;
-- 
2.34.1