[PATCH 2/2] rpmsg: smd: Remove redundant dev_err()
Pan Chuang <[email protected]> Thu, 16 Jul 2026 21:08:30 +0800
| Newsgroups | org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <[email protected]>
---
drivers/rpmsg/qcom_smd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 7dbe1c6efe41..9a300eea190e 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1421,10 +1421,8 @@ static int qcom_smd_parse_edge(struct device *dev,
ret = devm_request_irq(dev, irq,
qcom_smd_edge_intr, IRQF_TRIGGER_RISING,
node->name, edge);
- if (ret) {
- dev_err(dev, "failed to request smd irq\n");
+ if (ret)
goto put_node;
- }
edge->irq = irq;
--
2.34.1