Re: [PATCH v5 08/13] mips: Get rid of custom mips ABIs for syscall tables

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch modifies `arch/mips/kernel/syscalls/syscall_n64.tbl` (changing the ABI string to `common`) but fails to synchronize the mirrored copy at `tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl`.
--

--- Patch [8]: [PATCH v5 08/13] mips: Get rid of custom mips ABIs for syscall tables ---
commit 0da0a7952278891a02bb3187b7d10490c780e9c7
Author: André Almeida <[email protected]>
Date:   Wed Aug 12 17:38:39 2026 +0000

mips: Get rid of custom mips ABIs for syscall tables

This commit replaces the MIPS-exclusive ABI names (n32, o32, n64) with
"common" in the syscall tables. The goal is to simplify and unify the tables
without introducing any functional changes.

> diff --git a/arch/mips/kernel/syscalls/syscall_n64.tbl b/arch/mips/kernel/syscalls/syscall_n64.tbl
> index 630aab9e54259..9acc68729e218 100644
> --- a/arch/mips/kernel/syscalls/syscall_n64.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_n64.tbl
> @@ -5,384 +5,384 @@
>  # The format is:
>  # <number> <abi> <name> <entry point>
>  #
> -# The <abi> is always "n64" for this file.
> +# The <abi> is always "common" for this file.
>  #
> -0	n64	read				sys_read
> +0	common	read				sys_read

[Severity: Low]
Will this trigger a "Kernel ABI header differences" warning during the perf
build?

The kernel ABI header was modified to use "common" instead of "n64" here, but
it looks like the mirrored copy at 
tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl was not synchronized.
When tools/perf/check-headers.sh runs during the perf build, it will detect
that the two files are out of sync.

Should the tools/perf/ copies of the syscall tables be updated in this patch
as well to prevent the build warning?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8