Re: [PATCH v5 01/13] syscalls: Make --abis parsing more robust
| Newsgroups | org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
> Some archs Makefile have something like this as the rule for making the > syscall files: > > cmd_systbl = $(CONFIG_SHELL) $(systbl) --abis common,$* $< $@ > > The $* symbol is evaluated to the variable found at $(uapi)/unistd-%.h, > where % is 32 or 64, resulting in e.g. `--abis common,32`. Sometimes the > rule for the file won't have a %, resulting in a trailing comma e.g. > `--abis common,`. > > Currently this input is transformed into (common|). This is problematic > because grep will then match any ABI because of the trailing `|`. Make the > syscalls scripts more robust by removing any trailing comma. > > Signed-off-by: André Almeida <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1