Re: [PATCH v5 11/13] alpha: Define entry point for set_mempolicy_home_node syscall

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Interface Omission / Synchronization: The tools/perf copy of the alpha syscall table was not synchronized with the kernel table.
--

--- Patch [11]: [PATCH v5 11/13] alpha: Define entry point for set_mempolicy_home_node syscall ---
commit 65b94b8b8c8352e18befb0f4f62dfbedfd1fca90
Author: André Almeida <[email protected]>

alpha: Define entry point for set_mempolicy_home_node syscall
    
Instead of explicitly defining set_mempolicy_home_node as sys_ni_sycall in
the syscall table, define it as the real syscall entry point,
sys_set_mempolicy_home_node. As per commit fdb7d9b7acd0 ("alpha: remove
DISCONTIGMEM and NUMA"), alpha doesn't have NUMA support, so none of the
mempolicy sycalls will ever be compiled for alpha, resulting in the
COND_SYSCALL() fallback being used to result in the sys_ni_syscall.

> diff --git a/arch/alpha/kernel/syscalls/syscall.tbl b/arch/alpha/kernel/syscalls/syscall.tbl
> index f31b7afffc345..25180953c3c1a 100644
> --- a/arch/alpha/kernel/syscalls/syscall.tbl
> +++ b/arch/alpha/kernel/syscalls/syscall.tbl
> @@ -489,7 +489,7 @@
>  # 557 reserved for memfd_secret
>  558	common	process_mrelease		sys_process_mrelease
>  559	common  futex_waitv                     sys_futex_waitv
> -560	common	set_mempolicy_home_node		sys_ni_syscall
> +560	common	set_mempolicy_home_node		sys_set_mempolicy_home_node

[Severity: Low]
Does this also need to be updated in the perf tooling copy of the syscall
table at tools/perf/arch/alpha/entry/syscalls/syscall.tbl?

It looks like tools/perf/arch/alpha/entry/syscalls/syscall.tbl was left out
of sync and still contains the old sys_ni_syscall entry point for syscall 560.
While perf primarily parses the syscall number and name and might still work
correctly, keeping the tooling copies synchronized with the kernel table is
usually expected.

This isn't a bug introduced by this patch, but there is a pre-existing typo
in tools/perf/check-headers.sh. It checks for the non-existent path
arch/alpha/entry/ instead of arch/alpha/kernel/, which silently masks this
divergence during CI testing.

>  561	common	cachestat			sys_cachestat
>  562	common	fchmodat2			sys_fchmodat2
>  563	common	map_shadow_stack		sys_map_shadow_stack

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11