Re: [PATCH v5 12/13] alpha: Remove alpha_ prefix from custom syscall entries

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `clone3` syscall entry in the syscall table specifies `__clone3`, which does not match the actual assembly entry point `__sys_clone3` generated by the `fork_like` macro, causing a linkage failure.
--

--- Patch [12]: [PATCH v5 12/13] alpha: Remove alpha_ prefix from custom syscall entries ---
commit 849a21587e678cf6cc6690371a1a55c69f5ba4c5
Author: André Almeida <[email protected]>

alpha: Remove alpha_ prefix from custom syscall entries

This commit removes the alpha_ prefix from custom architecture-specific syscall
entry points and renames them to use the standard __sys_ prefix. This aligns
alpha with other architectures to make it easier to join the syscall tables.

> diff --git a/arch/alpha/kernel/entry.S b/arch/alpha/kernel/entry.S
> index fcfd06529b12e..5ca044efa2084 100644
> --- a/arch/alpha/kernel/entry.S
> +++ b/arch/alpha/kernel/entry.S
> @@ -863,9 +863,9 @@ ret_from_kernel_thread:
>  
>  .macro	fork_like name
>  	.align	4
> -	.globl	alpha_\name
> -	.ent	alpha_\name
> -alpha_\name:
> +	.globl	__sys_\name
> +	.ent	__sys_\name
> +__sys_\name:

[ ... ]

> diff --git a/arch/alpha/kernel/syscalls/syscall.tbl b/arch/alpha/kernel/syscalls/syscall.tbl
> index 25180953c3c1a..34151d1653d69 100644
> --- a/arch/alpha/kernel/syscalls/syscall.tbl
> +++ b/arch/alpha/kernel/syscalls/syscall.tbl

[ ... ]

> @@ -474,7 +474,7 @@
>  542	common	fsmount				sys_fsmount
>  543	common	fspick				sys_fspick
>  544	common	pidfd_open			sys_pidfd_open
> -545	common	clone3				alpha_clone3
> +545	common	clone3				__clone3

[Severity: Low]
Will this cause a linkage failure during the kernel build for the alpha
architecture due to an undefined symbol?

Because the fork_like macro in entry.S now prefixes entry points with
__sys_, the generated entry function for clone3 is __sys_clone3. Does this
table entry need to be updated to __sys_clone3 instead of __clone3 so that
it correctly resolves the assembly entry point?

>  546	common	close_range			sys_close_range
>  547	common	openat2				sys_openat2
>  548	common	pidfd_getfd			sys_pidfd_getfd

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12