RE: [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk

> -----Original Message-----
> From: Peter Griffin <[email protected]>
> Sent: Thursday, July 9, 2026 7:20 PM
> To: Alim Akhtar <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung
> Exynos8855 smdk
> 
> On Sat, 27 Jun 2026 at 17:54, Alim Akhtar <[email protected]> wrote:
> >
> > Add initial devicetree support for Samsung smdk board using
> > Exynos8855 SoC.
> > This SoC has Octa-core CPU with tri cluster architecture, a custom GPU
> > and a NPU supporting up to 14.7 TOPS apart from other supporting
> > peripheral and IPs.
> >
> > Commercially this SoC is also known as Exynos1580 [1]
> >
> > [1]
> > https://semiconductor.samsung.com/processor/mobile-processor/exynos-15
> > 80/
> >
> > Signed-off-by: Alim Akhtar <[email protected]>
> > ---
> >  arch/arm64/boot/dts/exynos/Makefile           |   1 +
> >  .../boot/dts/exynos/exynos8855-pinctrl.dtsi   | 574 ++++++++++++++++++
> >  .../arm64/boot/dts/exynos/exynos8855-smdk.dts |  32 +
> >  arch/arm64/boot/dts/exynos/exynos8855.dtsi    | 204 +++++++
> >  4 files changed, 811 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi
> >  create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
> >  create mode 100644 arch/arm64/boot/dts/exynos/exynos8855.dtsi
> > +       };
[snip]
> > +
> > +       oscclk: clock-oscclk {
> > +               compatible = "fixed-clock";
> > +               clock-output-names = "oscclk";
> > +               #clock-cells = <0>;
> > +       };
> 
> Small nit, but I believe oscclk node should be ordered alpha-numerically by the
> node name. See https://docs.kernel.org/devicetree/bindings/dts-coding-
> style.html
> 
Thanks, will update in v4 

> Peter
>