Re: [PATCH v3 5/6] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.linux-samsung-soc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 10/07/2026 11:55, Alim Akhtar wrote:
>>> ---
>>> arch/arm64/boot/dts/exynos/Makefile | 1 +
>>> .../boot/dts/exynos/exynos8855-pinctrl.dtsi | 574 ++++++++++++++++++
>>> .../arm64/boot/dts/exynos/exynos8855-smdk.dts | 32 +
>>> arch/arm64/boot/dts/exynos/exynos8855.dtsi | 204 +++++++
>>> 4 files changed, 811 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi
>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts
>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8855.dtsi
>>> + };
> [snip]
>>> +
>>> + oscclk: clock-oscclk {
>>> + compatible = "fixed-clock";
>>> + clock-output-names = "oscclk";
>>> + #clock-cells = <0>;
>>> + };
>>
>> Small nit, but I believe oscclk node should be ordered alpha-numerically by the
>> node name. See https://docs.kernel.org/devicetree/bindings/dts-coding-
>> style.html
>>
> Thanks, will update in v4
The node feels ordered, no? clock before cpu?
Best regards,
Krzysztof