[PATCH 4/5] serial: mctrl_gpio: Remove redundant dev_err()
Pan Chuang <[email protected]> Wed, 22 Jul 2026 11:43:32 +0800
| Newsgroups | org.kernel.vger.linux-serial,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() call.
Signed-off-by: Pan Chuang <[email protected]>
---
drivers/tty/serial/serial_mctrl_gpio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
index 7b02c5ca4afd..dff13a9f2614 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.c
+++ b/drivers/tty/serial/serial_mctrl_gpio.c
@@ -256,9 +256,6 @@ struct mctrl_gpios *mctrl_gpio_init(struct uart_port *port, unsigned int idx)
gpios);
if (ret) {
/* alternatively implement polling */
- dev_err(port->dev,
- "failed to request irq for %s (idx=%d, err=%d)\n",
- mctrl_gpios_desc[i].name, idx, ret);
return ERR_PTR(ret);
}
}
--
2.34.1