[PATCH 5/5] serial: sprd: Remove redundant dev_err()
Pan Chuang <[email protected]> Wed, 22 Jul 2026 11:43:33 +0800
| Newsgroups | org.kernel.vger.linux-serial,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() call.
Signed-off-by: Pan Chuang <[email protected]>
---
drivers/tty/serial/sprd_serial.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
index 092755f35683..3fdf5939a62c 100644
--- a/drivers/tty/serial/sprd_serial.c
+++ b/drivers/tty/serial/sprd_serial.c
@@ -741,11 +741,8 @@ static int sprd_startup(struct uart_port *port)
ret = devm_request_irq(port->dev, port->irq, sprd_handle_irq,
IRQF_SHARED, sp->name, port);
- if (ret) {
- dev_err(port->dev, "fail to request serial irq %d, ret=%d\n",
- port->irq, ret);
+ if (ret)
return ret;
- }
fc = serial_in(port, SPRD_CTL1);
fc |= RX_TOUT_THLD_DEF | RX_HFC_THLD_DEF;
serial_out(port, SPRD_CTL1, fc);
--
2.34.1