Re: [PATCH v2 1/4] ASoC: renesas: enable COMPILE_TEST for Migo-R / SIU

Hi Morimoto-san,

On Mon, 3 Aug 2026 at 03:55, Kuninori Morimoto
<[email protected]> wrote:
> Migo-R / SIU are not compiled with COMPILE_TEST, and there is no defconfig
> which selects them. So it is easy to be overlooked for compile test and/or
> ASoC updating.
>
> One of the reason is its complex depends / select.
>
> SND_SOC_SH4_SIU doesn't have tristate title, which means it needs to be
> selected from other CONFIG, and SND_SIU_MIGOR is it. And then, MIGOR /
> SIU has many duplicated and complex dependencies.
>
> Let's cleanup them and enable COMPILE_TEST when it was for
> SuperH / SH-Mobile.
>
> And remove #include <cpu/sh7722.h> which is not used, but be hinder for
> compile test.
>
> Signed-off-by: Kuninori Morimoto <[email protected]>

Thanks for your patch!

> --- a/sound/soc/renesas/Kconfig
> +++ b/sound/soc/renesas/Kconfig
> @@ -30,10 +30,6 @@ config SND_SOC_SH4_FSI
>
>  config SND_SOC_SH4_SIU
>         tristate
> -       depends on ARCH_SHMOBILE && HAVE_CLK
> -       depends on DMADEVICES
> -       select DMA_ENGINE
> -       select SH_DMAE
>         select FW_LOADER
>
>  config SND_SOC_RCAR
> @@ -75,7 +71,9 @@ config SND_SH7760_AC97
>
>  config SND_SIU_MIGOR
>         tristate "SIU sound support on Migo-R"
> -       depends on SH_MIGOR && I2C && DMADEVICES
> +       depends on SUPERH || ARCH_SHMOBILE

You can drop the ARCH_SHMOBILE part, as it is a subset of SUPERH
(if ARCH_SHMOBILE is enabled, SUPERH is enabled, too).

> +       depends on I2C

I am not sure you can drop DMADEVICES. Have you compile-tested without?

> +       depends on (SH_MIGOR && SH_DMAE) || COMPILE_TEST
>         select SND_SOC_SH4_SIU
>         select SND_SOC_WM8978
>         help

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds