Re: [PATCH v2 2/4] ASoC: renesas: enable COMPILE_TEST for PCM SH7760

Hi Morimoto-san,

On Tue, 4 Aug 2026 at 02:59, Kuninori Morimoto
<[email protected]> wrote:
> > > PCM SH7760 is not compiled with COMPILE_TEST, and there is no defconfig
> > > which selects it. So it is easy to be overlooked for compile test and/or
> > > ASoC updating.

Thanks for your patch!

> >
> > > -   depends on CPU_SUBTYPE_SH7760 && SH_DMABRG
> > > +   depends on SUPERH || ARCH_SHMOBILE

You can drop the ARCH_SHMOBILE part, as it is a subset of SUPERH
(if ARCH_SHMOBILE is enabled, SUPERH is enabled, too).

> > > +   depends on (CPU_SUBTYPE_SH7760 && SH_DMABRG) || COMPILE_TEST

You can drop the CPU_SUBTYPE_SH7760 part, as SH_DMABRG depends on
CPU_SUBTYPE_SH7760.

> > SH_DMABRG looks like an actual dependency, there's custom IRQ request
> > and free functions which don't have stubs.
>
> Ah...
> SH_DMABRG itself is depends on CPU_SUBTYPE_SH7760.
> So I think it should be "select" instead of "depends",
> like below.
>
>         depends on SUPERH || ARCH_SHMOBILE
>         depends on CPU_SUBTYPE_SH7760 || COMPILE_TEST
>         select SH_DMABRG

1. "depends on SH_DMABRG" should be fine, as SH_DMABRG is a
    user-visible symbol,
2. SH_DMABRG depends on CPU_SUBTYPE_SH7760, so you cannot just select
    it without enabling compile-testing for SH_DMABRG first.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds