Re: [PATCH 12/44] ASoC: codecs: cs35l*: use .auto_selectable_formats

--jQY7u+h6yaeNwfUt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 04, 2026 at 12:41:29AM +0000, Kuninori Morimoto wrote:
> We can use .auto_selectable_formats. Let's adds it.
>=20
> Signed-off-by: Kuninori Morimoto <[email protected]>

> +static const u64 cs35l35_selectable_formats =3D
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_PDM;
> +
>  static const struct snd_soc_dai_ops cs35l35_ops =3D {
>  	.startup =3D cs35l35_pcm_startup,
>  	.set_fmt =3D cs35l35_set_dai_fmt,
>  	.hw_params =3D cs35l35_hw_params,
>  	.set_sysclk =3D cs35l35_dai_set_sysclk,
> +	.auto_selectable_formats =3D &cs35l35_selectable_formats,
> +	.num_auto_selectable_formats =3D 1,
>  };

>  static const struct snd_soc_dai_ops cs35l35_pdm_ops =3D {
>  	.startup =3D cs35l35_pdm_startup,
>  	.set_fmt =3D cs35l35_set_dai_fmt,
>  	.hw_params =3D cs35l35_hw_params,
> +	.auto_selectable_formats	=3D &cs35l35_selectable_formats,
> +	.num_auto_selectable_formats	=3D 1,
>  };

This looks off, are you sure the _pdm_ops ought to support I2S?  I
suspect the other ops is really an I2S only one too.

--jQY7u+h6yaeNwfUt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpyIbEACgkQJNaLcl1U
h9DOkgf9GXVgHVhVim6wf7w2dDSyILtQOKcrCbMu5id3M55gUrMruwQwGBY5rVJL
Tm86Niz8lKdczWQ65Qo/UoDo99y0VRStcCLZ+SqzzMzyfBo0hlfoLq3LNBMQ169/
JSSObLnGwQtRKGbIbvXasesV6pvyTd8hcPcN8CXvwpgSIQrk+MW3HBFlSbqcFdil
Q4y72ONzZS+TV64PNEBaheZPfKKlJQ0mAgu/Tja2psLFdga3JJTY2oumWKitQIzN
rghzXLlusZ7H3p/Gcx52oYO0u0KnPuTHDuDUsrtvgc3usD8OMGT4X0suWAaBNF25
r+bvyQkl6LRDOWJLyVsx6niubca7ng==
=5FdI
-----END PGP SIGNATURE-----

--jQY7u+h6yaeNwfUt--