Re: [PATCH 13/44] ASoC: codecs: cs42*: use .auto_selectable_formats

Mark Brown <[email protected]> Tue, 4 Aug 2026 18:32:07 +0100
Newsgroups org.kernel.vger.linux-sound
Message-ID <[email protected]>
--zOGAHJ2tkhWlJktG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 04, 2026 at 12:41:33AM +0000, Kuninori Morimoto wrote:
> We can use .auto_selectable_formats. Let's adds it.

> +static const u64 cs4265_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J;
> +
>  static const struct snd_soc_dai_ops cs4265_ops = {
>  	.hw_params	= cs4265_pcm_hw_params,
>  	.mute_stream	= cs4265_mute,
>  	.set_fmt	= cs4265_set_fmt,
>  	.set_sysclk	= cs4265_set_sysclk,
> +	.auto_selectable_formats	= &cs4265_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>  	.no_capture_mute = 1,
>  };

The device has issues with _RIGHT_J for capture for some reason it seems
(see _hw_params(), some of the other devices look to be similar).

--zOGAHJ2tkhWlJktG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpyIhYACgkQJNaLcl1U
h9CBuAf+Ie+YaSEeUkgzN7GRPQ5NBCwDxLAR1QvsK+ryG/h9xnVl2lmlyMTf54Nm
wcqhFL62O9SADfsZnBIo0IES/Z+Xni/H19H+rFazsx4KhAtJsYR0WOK8K3/ut4qG
993t+0ggfDbGM0AyhpDgoFsujmk9KiBGTHQ7eqEZp0zDvyeMrnTvPDw+fySqKk9g
aHYX87sJKAoYSaytCUvgKBh7ldj7WFMn/kq6lhGSIydasR459nX5yWNWm2G1AEpM
bbZbkM2t7slR5MKWmGPGEBy/jIFits7j05eNNWRnTUinpmGAAt2+VDOw6b+dfNIm
cLEGpUiOONCzWDRnjMRwHhF7rx4Unw==
=fYlr
-----END PGP SIGNATURE-----

--zOGAHJ2tkhWlJktG--