Re: [PATCH 3/4] ASoC: tegra: tegra210_amx: Return the original error directly

Thierry Reding <[email protected]>
Newsgroups org.kernel.vger.linux-tegra,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID <aldzeLFDeu_tEszA@orome>
On Wed, Jul 15, 2026 at 12:11:14PM +0700, [email protected] wrote:
> From: bui duc phuc <[email protected]>
> 
> snd_soc_add_component_controls() already reports failures internally.
> Return its error code directly instead of logging the error again in the
> component probe callback. Also remove the now unnecessary local error
> variable.
> 
> Signed-off-by: bui duc phuc <[email protected]>
> ---
>  sound/soc/tegra/tegra210_amx.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

I suppose this could've been merged with the prior patch since it does
effectively the same thing. In either case:

Reviewed-by: Thierry Reding <[email protected]>
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmpXc5YACgkQ3SOs138+
s6EQGxAAwCnglsQ265MBp60O9zYxIXFCFowDZ4MQnyx+iie3AlPP2gFpaj/EgJF+
Cx7rzxGczXULoFsbequZzXH378Pklf0H6n4MoTgcMif5SwpFQE+X6YPOUQA7ZnhM
c/e8Xsygc/HSOHBN9DPydKOfIe6QD1RODvJOLDiJeqNC+Zb4oqNhN07ro+uPOp0P
KnGDqlQC3jxCU6UKGHTxk8Bjyi5T28HADshnfp6wDOfDD9UCslcpMAn+oJT1F/kd
I6ZCFO4LAY7VBUMjXnZSjNmH8PAEDS2fjdqXL/OBvt1CQG6o5RDpe1Y20oERWsVt
6AwnQQ58NUcvW5Z0FWnYOgSc+rfOzirKqjMTN9Hy0HqccFGDMNj1Gfq1nzZbUZV5
4hOPuLRcKbpw8Vt1vdpT/eZpWgpZWvW7Ya34vRHdZisuayVRo8O6weICA5cw1BJU
pDPwwFzURAeaOnSP4QhpDRkwsDtWpimJY+8I+9QYO8+7/gF06OygzVGEEaudtcps
LucnjrG51ouQC3psH4FHo8BXnrYA90J2tKrvMtX1oCQZzU9UL/+bL6pQAVtYhZlP
o2RTbGk2si5C8yY0j3RqNdjK7zkHSz82fB5rzQFo0T+NKLOJ7HeBUzRGBiHuE+kH
B9bxtEHn3hmNAID6bKwehnWFGFhbp2AYqQKgl1E3KdJmILH8DBU=
=pMtL
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.