Re: [PATCH 4/4] ASoC: tegra: tegra210: Use devm_clk_get_optional() for sync_input clock

Thierry Reding <[email protected]>
Newsgroups org.kernel.vger.linux-tegra,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID <ald0NfwnTmBsiM_j@orome>
On Wed, Jul 15, 2026 at 12:11:15PM +0700, [email protected] wrote:
> From: bui duc phuc <[email protected]>
> 
> The existing comment states that the sync_input clock is only needed
> when another I/O is configured to use the current I2S instance as its
> input clock, and the current code does not treat its absence as an
> error.
> Use devm_clk_get_optional() to match the existing behaviour while still
> reporting real failures via dev_err_probe(). Update the comment to
> describe the optional nature of the clock rather than the previous error
> handling.
> 
> Signed-off-by: bui duc phuc <[email protected]>
> ---
>  sound/soc/tegra/tegra210_i2s.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Thierry Reding <[email protected]>
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmpXdHgACgkQ3SOs138+
s6F2/g//R6Z8PVSVJHa/k17C5yXexk+ibyD0k518KFWDMmajhR7tBUXOA6+GhQ/8
XDFMhHGlNpskzPwt7YU0wKwjN6zq9WeW6Q9jhknvXhV1GoW2KRdMJ21QfHfaoooV
Ob8HaIh+Nm/60U4uP44WE5C/0HEKiymwrPKHE7zcNYBjNz+4kmgiz5lGkQ2SAN4J
coNWawc68oRTHbGRwPYs9QcuDqqpvANj6Rio1+SD3qBA4TaktV1U5eGkuPO8+Dno
U3ubu16QlH/57WgMZZPzCB5CR4Emt/ZMm2JdEUURRoqgjtabblT8+iWmvHu7NWy4
ApUAbx0fMpoAHOg5fH2MpHcobpMjKjO7JhdxvPM0/m9quPrOZZ/eT8kMfc8fZlnZ
69Dyfy+tDQ8PIMCAyppcogpOt7NJG6o2m5SFiC8RUkPJ5u8t7AAG5yy/+BGZXrg3
bQGqt038hUedNfHi/8NKJpnGKAtm0wsnV7C9wXIKgg8NJiTpJpoI0mH0K3y+VaTl
hJCjnULMYY31GMdJIu0zujevWWVMGQldh+8PB0oDIE7U8iQCN00i8Lw96SqzOtNy
n9qfpuL5usuCYWBnSOrLkyoRdLBYAd69Xm6cq3u8fLRlmF6p8yPGWfg4LBmwAFMM
M8E1xuKuI4GejEwugIyrvQ9d2JsFnnOqiYJ5aRmQKQRBcHZuliU=
=bEvT
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.