Re: [PATCH v4 19/39] unwind_user/sframe: Add support for reading .sframe contents
Jens Remus <[email protected]>
| Newsgroups | org.kernel.vger.linux-toolchains,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-trace-kernel |
|---|---|
| Organization | IBM Deutschland Research & Development GmbH |
| Message-ID | <[email protected]> |
On 22.01.2025 03:31, Josh Poimboeuf wrote:
> diff --git a/include/linux/sframe.h b/include/linux/sframe.h
> @@ -3,11 +3,14 @@
> #define _LINUX_SFRAME_H
>
> #include <linux/mm_types.h>
> +#include <linux/srcu.h>
> #include <linux/unwind_user_types.h>
>
> #ifdef CONFIG_HAVE_UNWIND_USER_SFRAME
>
> struct sframe_section {
> + struct rcu_head rcu;
> +
Nit: You are adding a blank line, that you later remove with
"[PATCH v4 25/39] unwind_user/sframe: Show file name in debug output".
> unsigned long sframe_start;
> unsigned long sframe_end;
> unsigned long text_start;
Regards,
Jens
--
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
[email protected]
IBM
IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/