Re: [PATCHv3 2/2] watchdog: pika_wdt: enable COMPILE_TEST builds

On 6/8/26 16:46, Rosen Penev wrote:
> On Mon Jun 8, 2026 at 3:55 PM PDT, Guenter Roeck wrote:
>> On 6/8/26 14:04, Rosen Penev wrote:
>>> Replace powerpc-specific I/O accessors (in_be32/out_be32) with
>>> generic ones (ioread32be/iowrite32be) so the driver can be
>>> compile-tested on other architectures.  Relax the Kconfig
>>> dependency accordingly and add the required HAS_IOMEM.
>>>
>>> Assisted-by: opencode:big-pickle
>>> Signed-off-by: Rosen Penev <[email protected]>
>>
>>
>> I really don't think this is worth the trouble just to be able
>> to support COMPILE_TEST on all architectures. This is an old watchdog
>> driver. It should not be touched except to fix bugs.
>>
>> Didn't I say that before ?
> Sounds like this driver should be left alone then.

Very much so. The driver is for a FPGA based system from around 2007,
and the company behind it went bankrupt in 2022. I would be surprised
if the current Linux kernel even boots on it.

Guenter