[PATCH v1] watchdog: sc1200: Drop unused assignment of pnp_device_id driver data
Uwe Kleine-König (The Capable Hub) <[email protected]>
| Newsgroups | org.kernel.vger.linux-watchdog,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <0793f81a854f9e5880ad38f54c8583b3d56e5d60.1781081216.git.u.kleine-koenig@baylibre.com> |
The driver explicitly sets the .driver_data member of struct pnp_device_id to zero without relying on that value. Drop this unused assignments. While touching this array simplify the list terminator. This patch doesn't modify the compiled array, only its representation in source form benefits. The former was confirmed with builds on x86 and arm64. Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]> --- Hello, I intend to change struct pnp_device_id and for that it's required that .driver_data is not assigned using a list initializer. Instead of converting it to a named initializer, drop the assignment as the value is unused. So this is both a cleanup and a preparation for a later patch series. See https://lore.kernel.org/all/[email protected]/ for a more verbose description on the mentioned change to struct pnp_device_id (though this is about platform_device_id, but the idea here is the same). Best regards Uwe drivers/watchdog/sc1200wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/sc1200wdt.c b/drivers/watchdog/sc1200wdt.c index 76a58715f665..1d3300c98d43 100644 --- a/drivers/watchdog/sc1200wdt.c +++ b/drivers/watchdog/sc1200wdt.c @@ -339,8 +339,8 @@ static int __init sc1200wdt_probe(void) static const struct pnp_device_id scl200wdt_pnp_devices[] = { /* National Semiconductor PC87307/PC97307 watchdog component */ - {.id = "NSC0800", .driver_data = 0}, - {.id = ""}, + { .id = "NSC0800" }, + { } }; static int scl200wdt_pnp_probe(struct pnp_dev *dev, base-commit: 49e02880ec0a8c378e811bc9d85da188d7c6204c -- 2.47.3