Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The deprecation warning message instructs users to pass a register offset via 'renesas,sys', contradicting the schema which restricts it to an IP instance index.
--
commit dd09e9278d1657dcf283ff0886c7ec9901f648a4
Author: Lad Prabhakar <[email protected]>
dt-bindings: watchdog: renesas,r9a09g057-wdt: Add SYS syscon support
This commit introduces a renesas,sys phandle-array property to allow the WDT
driver to access its control register via the system controller. It also
deprecates the second reg entry in favor of this new approach.
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas,r9a09g057-wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,r9a09g057-wdt.yaml
> --- a/Documentation/devicetree/bindings/watchdog/renesas,r9a09g057-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,r9a09g057-wdt.yaml
> @@ -48,6 +48,17 @@ properties:
> resets:
> maxItems: 1
>
> + renesas,sys:
> + description:
> + System controller registers control the start/stop of the WDT, and halt debug.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to system controller
> + - description: watchdog IP instance index
> + minimum: 0
> + maximum: 5
> +
[ ... ]
> + else:
> + properties:
> + reg:
> + description: Deprecated. Use renesas,sys to pass the offset
> + of WDTDCR register instead.
[Severity: Low]
Is this deprecation message accurate regarding passing an offset?
Looking at the renesas,sys property definition added above, it expects a
watchdog IP instance index with a maximum value of 5, rather than a register
offset.
Could this description mislead device tree authors into providing a raw
register offset instead of an index, leading to schema validation failures?
> + minItems: 2
> + deprecated: true
>
> additionalProperties: false
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.