Re: [PATCH 05/11] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles
[email protected] Thu, 09 Jul 2026 07:45:25 +0000
| Newsgroups | org.kernel.vger.linux-watchdog,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The commit message contains a typographical error when listing the newly added compatible strings. It incorrectly claims to add '"apple,t6030-pmgr-pwrstate" for M3 Pro and "apple,t6030-pmgr-pwrstate" for M3 Max and Ultra', repeating 't6030' instead of correctly stating that 'apple,t6031-pmgr-pwrstate' was added for the M3 Max and Ultra, which matches the actual patch contents. -- --- Patch [5]: [PATCH 05/11] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles --- commit a32e592d592072e4f59a9b2c56534397db2aadf2 Author: Janne Grunau <[email protected]> dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles This commit adds the apple,t6030-pmgr-pwrstate and apple,t6031-pmgr-pwrstate compatible strings for Apple M3 Pro, Max, and Ultra SoCs. > dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles > > The pmgr-powerstate registers on Apple M3 Pro, Max and Ultra SoCs are > compatible with "apple,t8103-pmgr-pwrstate". Add > "apple,t6030-pmgr-pwrstate" for M3 Pro and "apple,t6030-pmgr-pwrstate" > for M3 Max and Ultra as per-SoC compatibles. [Severity: Low] This isn't a bug, but should the second compatible string mentioned in the description be apple,t6031-pmgr-pwrstate to match the changes made in the patch? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260709-apple-t603x-initial-devices-v1-0-55b305833123@jannau.net?part=5