[PATCH v2 1/2] watchdog: orion_wdt: Propagate errors from optional IRQ lookup
| Newsgroups | org.kernel.vger.linux-watchdog,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
From: bui duc phuc <[email protected]> platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no IRQ is available, while other errors should be propagated. Propagate errors such as -EPROBE_DEFER and -EINVAL instead of continuing probe without the IRQ. Signed-off-by: bui duc phuc <[email protected]> --- Link v1: https://lore.kernel.org/all/[email protected]/ Changes in v2: - Update the commit message and error handling. - Propagate all errors from platform_get_irq_optional() except -ENXIO, instead of only handling -EPROBE_DEFER. drivers/watchdog/orion_wdt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c index 0e145f762f6f..f79a14c4e222 100644 --- a/drivers/watchdog/orion_wdt.c +++ b/drivers/watchdog/orion_wdt.c @@ -606,6 +606,8 @@ static int orion_wdt_probe(struct platform_device *pdev) /* Request the IRQ only after the watchdog is disabled */ irq = platform_get_irq_optional(pdev, 0); + if (irq < 0 && irq != -ENXIO) + return irq; if (irq > 0) { /* * Not all supported platforms specify an interrupt for the -- 2.43.0