[PATCH v2 2/2] watchdog: stm32_iwdg: Propagate errors from optional IRQ lookup
| Newsgroups | org.kernel.vger.linux-watchdog,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
From: bui duc phuc <[email protected]> platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no IRQ is available, while other errors should be propagated. Propagate errors such as -EPROBE_DEFER and -EINVAL instead of continuing probe without the IRQ. Signed-off-by: bui duc phuc <[email protected]> --- Link v1: https://lore.kernel.org/all/[email protected]/ Changes in v2: - Update the commit message and error handling. - Propagate all errors from platform_get_irq_optional() except -ENXIO, instead of only handling -EPROBE_DEFER. drivers/watchdog/stm32_iwdg.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index b356a272ff9a..a8d2db2d3cf8 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -287,8 +287,11 @@ static int stm32_iwdg_irq_init(struct platform_device *pdev, return 0; irq = platform_get_irq_optional(pdev, 0); - if (irq <= 0) + if (irq < 0) { + if (irq != -ENXIO) + return irq; return 0; + } if (of_property_read_bool(np, "wakeup-source")) { ret = devm_device_init_wakeup(dev); -- 2.43.0