Re: [PATCH wireless-next 1/7] wifi: mac80211: fix IEEE80211_TX_CTL_REQ_TX_STATUS mixup
Jeff Johnson <[email protected]> Mon, 3 Aug 2026 18:05:20 -0700
| Newsgroups | org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 8/3/2026 7:08 AM, Johannes Berg wrote: > From: Johannes Berg <[email protected]> > > In ieee80211_build_hdr(), IEEE80211_TX_CTL_REQ_TX_STATUS is checked > in ctrl_flags, which is wrong - IEEE80211_TX_CTL_REQ_TX_STATUS is in > info->flags, so the check is for IEEE80211_TX_CTRL_PORT_CTRL_PROTO > instead. This works out OK because the only place setting _that_ at > a point before this gets called is in fact ieee80211_tx_control_port() > which was intended here. This is actually needed for correctness, if > jt were checking info->flags instead, TDLS would fill/leak the status nit: s/jt/it/ > frames created here.