Re: [PATCH wireless-next 7/7] wifi: mac80211: store the ack skb before building the header
Jeff Johnson <[email protected]> Mon, 3 Aug 2026 18:09:14 -0700
| Newsgroups | org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 8/3/2026 7:08 AM, Johannes Berg wrote: > From: Johannes Berg <[email protected]> > > The ack skb has to be stored while the frame is still in 802.3 > format, since that is what is reported back to userspace. It's > currently done in ieee80211_build_hdr(), but that complicates > it a bit. > > Thanks the the previous ieee80211_lookup_ra_sta() change, it's nit: s/the the/to the/ > now known whether or not the frame will be group addressed on > the air, which is needed for this condition. > > Also simplify callers of ieee80211_store_ack_skb() by filling > the TX info directly and fix the free in ieee80211_build_hdr() > to use ieee80211_free_txskb(), reporting the drop to userspace > rather than being quiet about it. > > This also lets use validate the link ID for control port TX in s/use/us/ ?? > that code itself, rather than interleaving it into build_hdr(). > > Signed-off-by: Johannes Berg <[email protected]> > ---