Re: [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset

On 04/08/2026 16:07, Markuss Broks via B4 Relay wrote:
> From: Markuss Broks <[email protected]>
>
> Those are the required changes for the BCM4361 PCIe chipset support.

Hi Markuss,

That is a brief commit message. Maybe you can provide a bit of context 
for this patch answering these questions: Are you using this device in 
some project? What platform are you using (if any)? What works and what 
does not?

> Signed-off-by: Markuss Broks <[email protected]>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.

This really does not look very useful. Those EDITME: are for you! As the
actual patch did not change you can probably say:
   - fix subject format indicating wifi subsystem and wireless-next repo.

> - Link to v1: 
> https://patch.msgid.link/[email protected]
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c       | 3 +++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 3 +++
> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++
> 3 files changed, 8 insertions(+)

[...]

> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c 
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index 55f4d7b970f2..914ae72a7b74 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -59,6 +59,7 @@ BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie");
> BRCMF_FW_DEF(4358, "brcmfmac4358-pcie");
> BRCMF_FW_DEF(4359, "brcmfmac4359-pcie");
> BRCMF_FW_DEF(4359C, "brcmfmac4359c-pcie");
> +BRCMF_FW_CLM_DEF(4361, "brcmfmac4361-pcie");

Are you sure the CLM blob is required? Can you test without it being 
present in /lib/firmware?

> BRCMF_FW_CLM_DEF(4364B2, "brcmfmac4364b2-pcie");
> BRCMF_FW_CLM_DEF(4364B3, "brcmfmac4364b3-pcie");
> BRCMF_FW_DEF(4365B, "brcmfmac4365b-pcie");

[...]

> diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h 
> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> index df3b67ba4db2..b800cbfdece1 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h

[...]

> @@ -86,6 +87,7 @@
> #define BRCM_PCIE_43602_2G_DEVICE_ID 0x43bb
> #define BRCM_PCIE_43602_5G_DEVICE_ID 0x43bc
> #define BRCM_PCIE_43602_RAW_DEVICE_ID 43602
> +#define BRCM_PCIE_4361_DEVICE_ID 0x441f

Please add:
+#define BRCM_PCIE_4361_2G_DEVICE_ID 0x4420
+#define BRCM_PCIE_4361_5G_DEVICE_ID 0x4421

Regards,
Arend

> #define BRCM_PCIE_4364_DEVICE_ID 0x4464
> #define BRCM_PCIE_4365_DEVICE_ID 0x43ca
> #define BRCM_PCIE_4365_2G_DEVICE_ID 0x43cb