RE: [PATCH] wifi: rtlwifi: rtl8192cu: Remove logically dead code in rtl92cu_update_hal_rate_mask

Chelsy Ratnawat <[email protected]> wrote:
> The variable 'mimo_ps' is initialized to IEEE80211_SMPS_OFF and never
> modified throughout the function. This makes the condition checking for
> IEEE80211_SMPS_STATIC always evaluate to false, rendering the entire
> if-branch unreachable dead code.
>=20
> This error was reported by Coverity Scan.

The 'error' seems too strong... I'd change this to warning.

Also add parenthesis to function name of subject -- i.e. rtl92cu_update_hal=
_rate_mask().

(no need to resend)

>=20
> Signed-off-by: Chelsy Ratnawat <[email protected]>

Acked-by: Ping-Ke Shih <[email protected]>