RE: [PATCH] wifi: rtlwifi: rtl8192cu: Remove logically dead code in rtl92cu_update_hal_rate_table

Chelsy Ratnawat <[email protected]> wrote:
> The variable 'mimo_ps' is initialized to IEEE80211_SMPS_OFF and never
> modified throughout the function. This makes the condition checking for
> IEEE80211_SMPS_STATIC always evaluate to false, rendering the entire
> if-branch unreachable dead code.
>=20
> This error was reported by Coverity Scan.

Similarly, I'd change 'error' to 'warning', and use rtl92cu_update_hal_rate=
_table()
instead in subject.

By the way, I see other places using IEEE80211_SMPS_OFF have similar dead c=
ode.
Patches are welcome to remove them.

>=20
> Signed-off-by: Chelsy Ratnawat <[email protected]>

Acked-by: Ping-Ke Shih <[email protected]>