Re: [PATCH v5 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint

On Wed, Aug 19, 2026 at 8:27 PM Krzysztof Kozlowski <[email protected]> wrote:
>
> On 19/08/2026 13:42, George Valkov wrote:
> > On Wed, 19 Aug 2026 at 12:42, Krzysztof Kozlowski <[email protected]> wrote:
> >>
> >> On Tue, Aug 18, 2026 at 12:54:26AM +0300, Georgi Valkov wrote:
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
> >>> index 930b700b73d0..5f235cb9f3e5 100644
> >>> --- a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
> >>> +++ b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
> >>> @@ -59,6 +59,12 @@ properties:
> >>>      description: Calibration data for sub-band 3 in the 5GHz band.
> >>>      maxItems: 502
> >>>
> >>> +  marvell,ignore-regulatory-hint:
> >>> +    $ref: /schemas/types.yaml#/definitions/flag
> >>> +    description:
> >>> +      Ignore an incorrect regulatory hint from ROM,
> >>> +      so userspace can set the correct regulatory domain.
> >>> +
> >>
> >> Same comments, so you just ignored entire feedback?
> >
> > Do you mean this feedback? I already replied to it:
> >>> Anyway, property looks like SW choice. You must describe hardware
> >>> instead.
> >>
> >> I am sorry, I do not understand what you want me to do?
> >> Can you please send a diff or a clear description suitable for people
> >> who have way less experience than you?
> >
> >
> >> Again: you need to describe the hardware, in commit msg, in property
> >> name and in description. You cannot tell SW what to do, that's not the
> >> purpose of bindings.
> >
> > I still don't understand what I should do?
> > Can you please show me an example of the changes you want?
> > Else I'm likely to make a wrong guess and implement it. That obviously
> > won't help.
> >
> > The commit message already describes the issue with WRT3200ACM and WRT32x.
> >
> > About the description, do you want me to do something like this?
> >     description:
> >       Ignore an incorrect regulatory hint from ROM,
> >       so userspace can set the correct regulatory domain.
> > +    WRT3200ACM and WRT32x are known to need this.
> >
> > About the property name or flag, do you want me to add a separate flag
> > for each affected hardware device?
> > - wrt3200acm,ignore-regulatory-hint
> > - wrt3200x,ignore-regulatory-hint
> > - the list may grow if someone decides to add other devices
> > - and the driver will need to support all of them
> > - that doesn't make sense, because it isn't scalable
>
> You need to describe the actual problem in the hardware or firmware, and
> then name the property and description accordingly. "Ignore regulatory
> hint" is clear instruction to the OS what it should do - ignore the
> wireless-regdb package/instruction etc.

You probably have it backwards. The driver is taking the hint from the
hardware ROM, which is fixed and thus wrong once someone carries the
device to a different country. I.e. it is a quirk saying the _hardware_
region should not be used.

Whether one should override the certified settings, or be able to do that,
is a whole different discussion.


ChenYu

> >
> >> How did you fix the threading problem I mentioned in v3?
> >
> > How can I fix a threading problem?
> > I don't really know what the correct thing to do is, once I forgot to add
> > a version tag in v4. So I just added v5 in my next submission.
> > I'm new to sending mails using git. So far I've learned that I can do this:
> > git send-email --thread --in-reply-to=<Message-ID> …
> > and I use the last Message-ID.
>
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets. See also:
> https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830
>
> Look how correct thread looks like for v37:
> https://lore.kernel.org/linux-devicetree/[email protected]/#r
>
> Look at this v5 thread - it is one huge chain:
> https://lore.kernel.org/linux-devicetree/[email protected]/#r
>
>
> Best regards,
> Krzysztof