Re: [PATCH] wifi: ath12k: ahb: Revert undocumented ABI and dead code
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.linux-wireless,org.infradead.lists.ath12k,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 25/08/2026 10:13, Krzysztof Kozlowski wrote:
> Commit 96f46607bbce ("wifi: ath12k: add AHB platform descriptor
> support") added undocumented OF ABI, by relying on a very specific node
> name. This is not allowed and was never acked by Devicetree
> maintainers.
>
> Additionally that part of code is not even used, because all devices
> have exactly the same user pd, so this was added "for future". Adding
> dead code just "for future" is heavily discouareged in kernel coding.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/net/wireless/ath/ath12k/wifi7/ahb.c | 51 +--------------------
> 1 file changed, 1 insertion(+), 50 deletions(-)
>
Unfortunately the offending commit was merged for v7.3-rc1, thus please
take this to current RC as well.
Best regards,
Krzysztof