RE: [PATCH v7 4/6] wifi: rtw88: sdio: track free TX pages and OQT credits for RTL8723BS

Luka Gejak <[email protected]> wrote:
> Do you mind answering this question, it seems like you missed it:
> 
> The unaligned SKB warning now sits in both callers rather than once inside
> rtw_sdio_write_to_port(), because __func__ would otherwise report
> rtw_sdio_write_to_port for every other SDIO chip where it reports
> rtw_sdio_write_port today. Keeping that message identical costs three
> duplicated lines. Putting it once in rtw_sdio_write_to_port() is the
> tidier code and arguably the more accurate message, at the price of
> changing a log line on chips this series is not about. I went with the
> duplicate to leave the other parts alone, but I have no strong feeling
> either way, so say which you prefer.

Do you mean this?

	if (!IS_ALIGNED((unsigned long)skb->data, RTW_SDIO_DATA_PTR_ALIGN))
		rtw_warn(rtwdev, "Got unaligned SKB in %s() for queue %u\n",
			 __func__, queue);

But I don't find rtw_sdio_write_to_port()?

Is this a normal case? Can current sdio.c handle this properly?
If so, I'd change to debug level. 

If your question is whether duplicate of this message, please point
the codes for me. (Sorry, I can't find the code you mentioned by v7).

Ping-Ke