Re: [PATCH 4/6] xfs: don't zap the attr fork on repair when there are queued pptr updates
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jul 23, 2026 at 11:22:03PM -0700, Darrick J. Wong wrote:
> - if (rx->attrs_found == 0) {
> + if (rx->attrs_found == 0 && (!xfs_has_parent(sc->mp) ||
> + xfarray_length(rx->pptr_recs) == 0)) {
Hmm, this formatting looks at least a bit confusing. Why not:
if (rx->attrs_found == 0 &&
(!xfs_has_parent(sc->mp) || xfarray_length(rx->pptr_recs) == 0)) {
?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <[email protected]>