Re: [PATCH 5/6] xfs: nlink scrub must take IOLOCK before determining ILOCK state
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jul 23, 2026 at 11:22:18PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <[email protected]> > > In xchk_nlinks_ilock_dir, take the IOLOCK before accessing internal > inode state to figure out if we need to take ILOCK shared or exclusive. > That way we can't race with directory updates. LOLLM pointed out that > the code was initially correct w.r.t. the IOLOCK, but then I broke it. Looks good: Reviewed-by: Christoph Hellwig <[email protected]>