Re: [PATCH 2/2] xfs: add a comment to describe xfs_gc_bio.victim_rtg

On 7/28/26 17:06, Christoph Hellwig wrote:
> All other fields have comments describing them, add one for this field
> as well.
> 
> Signed-off-by: Christoph Hellwig <[email protected]>

Looks good to me (see nit below).

Reviewed-by: Damien Le Moal <[email protected]>

> ---
>  fs/xfs/xfs_zone_gc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
> index e4f70e024632..e2bad83b10f6 100644
> --- a/fs/xfs/xfs_zone_gc.c
> +++ b/fs/xfs/xfs_zone_gc.c
> @@ -103,6 +103,7 @@ struct xfs_gc_bio {
>  	/* Open Zone being written to */
>  	struct xfs_open_zone		*oz;
>  
> +	/* Realtime group currently evacuated */

May be: /* Realtime group currently being reclaimed */ ?

>  	struct xfs_rtgroup		*victim_rtg;
>  
>  	/* Bio used for reads and writes, including the bvec used by it */


-- 
Damien Le Moal
Western Digital Research