Re: [PATCH 1/2] xfs: add a separate bio_set for spliting GC writes
Damien Le Moal <[email protected]> Wed, 29 Jul 2026 13:07:44 +0900
| Newsgroups | org.kernel.vger.linux-xfs |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 7/28/26 17:06, Christoph Hellwig wrote:
> Allocating the new bio for a split from the same pool as the original
> one can deadlock under memory pressure. Add a separate pool for
> splitting GC write bios to avoid this.
>
> Fixes: 080d01c41d44 ("xfs: implement zoned garbage collection")
> Signed-off-by: Christoph Hellwig <[email protected]>
Looks good to me, but the commit message would be better with an explanation of
how the deadlock can happen, as I do not think it is that obvious.
Regardless,
Reviewed-by: Damien Le Moal <[email protected]>
--
Damien Le Moal
Western Digital Research