Re: [PATCH 1/6] xfs: fix unit conversions in per_binval computation
Christoph Hellwig <[email protected]> Thu, 30 Jul 2026 10:18:39 +0200
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jul 29, 2026 at 10:26:18PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <[email protected]> > > LOLLM noticed that we're doing the unit conversion in the per_binval > computation backwards -- xfs_buf_inval_log_space's second parameter is > supposed to be in bytes, but max_binval is in units of fsblocks. Hence > the conversion should be FSB -> B, not the other way around. Oops. Looks good: Reviewed-by: Christoph Hellwig <[email protected]>