Re: [PATCH 2/6] xfs: fix short ifork reaping computation in xreap_bmapi_binval

Christoph Hellwig <[email protected]> Thu, 30 Jul 2026 10:19:12 +0200
Newsgroups org.kernel.vger.linux-xfs,org.kernel.vger.stable
Message-ID <[email protected]>
On Wed, Jul 29, 2026 at 10:26:33PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <[email protected]>
> 
> LOLLM got really confused about the update to imap->br_blockcount in
> xreap_bmapi_binval if xreap_inc_binval returns false.  The intent of
> this code is that we shorten the imap to whatever length of space we
> invalidated so that the next iteration through the loop will start
> wherever we left off.  Unfortunately, the calculation sets br_blockcount
> to the amount of *unfinished* work, which means that we pointlessly
> re-scan blocks that we already reaped.  This is benign, but we should
> fix the computation anyway.

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>